Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tangle-dapp): Implement LS pools update roles modal #2675

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

yurixander
Copy link
Member

@yurixander yurixander commented Nov 26, 2024

Summary of changes

Provide a detailed description of proposed changes.

  • ➕ Added the ability to update LS pool roles via a modal that initiates a transaction. This option automatically comes up if the user has the root role of any pools.
  • 🔧 Improved amount/balance formatting consistency across the dApp.
  • 🔧 Refactored code to make consistent use of the different address types: SubstrateAddress, EvmAddress20, and EvmAddress32. By differentiating each type, it helps prevent possible logic bugs in the future and also improves DX.
  • 🐛 Fixed bug with the Update Commission modal where the modal footer was duplicated.

Proposed area of change

Put an x in the boxes that apply.

  • apps/tangle-dapp
  • apps/tangle-cloud
  • libs/tangle-shared-ui
  • libs/webb-ui-components

Associated issue(s)

Specify any issues that can be closed from these changes (e.g. Closes #233).

Screen Recording

If possible provide screenshots and/or a screen recording of proposed change.

@yurixander yurixander self-assigned this Nov 26, 2024
Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for tangle-cloud failed. Why did it fail? →

Name Link
🔨 Latest commit 7bbcf02
🔍 Latest deploy log https://app.netlify.com/sites/tangle-cloud/deploys/674caa0d051b7e0008f1011e

Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for tangle-dapp failed. Why did it fail? →

Name Link
🔨 Latest commit 7bbcf02
🔍 Latest deploy log https://app.netlify.com/sites/tangle-dapp/deploys/674caa0d7bf2b400088a45d6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Building 🏗️
Development

Successfully merging this pull request may close these issues.

[FEAT] LS pool modal: Update roles
1 participant