-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does it make sense to implement audio quality tags for albums as well? #256
Comments
media Metadata is not populated for every album so that was the treason I didn't add it back then. I have not recently looked at album mediaMetadata and what we can expect to find in it and if we can expect that it is always available nowadays. I'd also be interested to see if it contains more useful information to deduce if the album is mqa, hires, lossless etc. Especially since we often have several identical albums with the same name. But the main issue i see is that an album can contain tracks that do not necessarily have the same quality available. A good example is the latest album by Pearl Jam, where the quality changes between HIRES_LOSSLESS and HIRES. |
I haven't seen an album without any metadata so far.
That is true. But I think having such properties as an general indicator and also stating this within the code would still be very beneficial. Shall we implement this? |
I noticed it a few times while testing. The real issue occurs when parsing the album object associated with a given track so it is not the album itself that is missing this field. In this case, the Anyways, regarding the media metadata. In the examples I've looked at, the album media metadata matches the track metadata so they can be used to determine the general audio quality of the album that is available from tidal servers (but not necessarily from the selected album!)
Agreed, this would be a good idea to add for the albums as well but of course we'd need to handle the situation where the media metadata is not populated. And the comment would need to reflect that the actual media metadata may NOT correspond to the album media metadata. |
if I want to add the highest quality version of an album to a playlist, the expected flow would be: how can I do that?
|
There are already flags for tracks, like
is_Mqa
python-tidal/tidalapi/media.py
Lines 402 to 415 in 6fb5289
Thus, I can determine very easily, what kind of quality this track has. But
Album
has also MetaDataTags. Would it also make sense, to implement suchis_*
properties for albums as well, wouldn't it?The text was updated successfully, but these errors were encountered: