Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring work #193

Open
6 tasks
2e0byo opened this issue Sep 3, 2023 · 1 comment
Open
6 tasks

Refactoring work #193

2e0byo opened this issue Sep 3, 2023 · 1 comment

Comments

@2e0byo
Copy link
Collaborator

2e0byo commented Sep 3, 2023

  • Methods which don't use self should be static or classmethods.
    We have quite a lot of these in things like TextBlock.parse. Personally I'd also like to rename this .from_json.
  • Remove sentinel None on class where not optional (over-use of optionals) (See also Spec of Session should be fully exposed on class #192)
  • Set spec on class (see also Spec of Session should be fully exposed on class #192)
  • Use ABCs to enforce consistent spec of objects, e.g. artist/album
  • Config needs refactoring
  • (easy: good first PR) we should clean up old syntax, e.g. inheriting from object, super(class, self) -> super()
@2e0byo
Copy link
Collaborator Author

2e0byo commented Sep 3, 2023

Feel free to make suggestions/challenges here; let's link in refactoring issues so we can keep track of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant