Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Training loop for generator uses fake output from generator pre-update #140

Closed
AtheMathmo opened this issue Mar 8, 2021 · 1 comment
Closed

Training loop for generator uses fake output from generator pre-update #140

AtheMathmo opened this issue Mar 8, 2021 · 1 comment

Comments

@AtheMathmo
Copy link

SinGAN/SinGAN/training.py

Line 175 in 1b4906b

output = netD(fake)

I'd appreciate confirmation that this is indeed a bug. It looks to me like the generator output is not updated after the first step of the generator update loop.
@AtheMathmo
Copy link
Author

I see now there is already some discussion of this issue in pull requests #126 and #117 . I'll close this issue for now, but feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AtheMathmo