Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is jest-environment-jsdom really a dependency? #106

Open
CodeCommander opened this issue Aug 3, 2023 · 0 comments
Open

Is jest-environment-jsdom really a dependency? #106

CodeCommander opened this issue Aug 3, 2023 · 0 comments

Comments

@CodeCommander
Copy link

Is jest-environment-jsdom really a dependency or should it be in the devDependencies? This seems like it is probably not required in production since it is part of a testing framework. My NPM is complaining about mismatched node versions for some of the dependencies of jest-environment-jsdom.
CodeCommander added a commit to pndlm/react-compare-image that referenced this issue Aug 4, 2023
@CodeCommander
fix tam315#106: move jest-environment-jsdom to devDependencies
a81a5c0
CodeCommander added a commit to pndlm/react-compare-image that referenced this issue Aug 4, 2023
@CodeCommander
fix tam315#106: pnpm is also a required dev dependency for the build …
f114026 
…command.
CodeCommander added a commit to pndlm/react-compare-image that referenced this issue Aug 4, 2023
@CodeCommander
fix tam315#106: update package-lock.json
95b9a53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CodeCommander