Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing issue in get_semantic and downstream consequences #87

Open
danmarinescu opened this issue Jul 5, 2023 · 0 comments
Open

Typing issue in get_semantic and downstream consequences #87

danmarinescu opened this issue Jul 5, 2023 · 0 comments

Comments

@danmarinescu
Copy link

Hi, thanks for building this library! We recently upgraded from version 1.3.2 to 2.2.1 and some of our tests are now failing. For example if we do

xpub_key="drkvjRAvbKRoPGwQKSY4bSbbDrUv1zTH8bUTQDeyEBNGws5BZUwec5wNeNwJqzYSSqC5CTsD7AMvun5RMmi39GjMfELNfF4cwB6DhLG7aTQfUST"
symbol="DASH"
is_root_xpublic_key(xpublic_key=xpub_key, symbol=symbol)

This raises an exception here because get_semantic returns None.

According to the type annotation get_semantic returns a non-optional string and therefore should not return None. Is the type annotation wrong? How should the code handle the above case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant