New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance Degradation from 0.2.0 to 1.1.0 #7

Open

csek06 opened this issue Apr 23, 2021 · 0 comments

csek06 commented Apr 23, 2021 •

edited

Loading

I've been using this wallet to generate vanity public addresses and have found a degradation in performance from version 0.2.0 to 1.1.0

Steps to reproduce
generate a list of 1,000 mnemomics (not using this wallet for)
convert those mnemonics to public addresses via below methods

hdwallet: HDWallet = HDWallet(cryptocurrency=EthereumMainnet)
def getAddress(seed, path):
	hdwallet.clean_derivation()
	hdwallet.from_mnemonic(mnemonic=seed)
	hdwallet.from_path(path)
	address = str(hdwallet.address()).strip()
	return address

you will see that just by going from version 0.2.0 to 1.1.0 it's about 33% slower

Note - I did change the import statement to the newer version to make the code work...

from hdwallet.derivations import BIP44Derivation
hdwallet: BIP44HDWallet = BIP44HDWallet(cryptocurrency=EthereumMainnet)

meherett added a commit that referenced this issue


          Merge pull request #7 from chainxlab/itsm3abena/docs

cad3162

Itsm3abena/docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment