Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring pre v0.0.2 #27

Merged
merged 16 commits into from
Dec 13, 2022
Merged

Refactoring pre v0.0.2 #27

merged 16 commits into from
Dec 13, 2022

Conversation

talmo
Copy link
Contributor

@talmo talmo commented Nov 10, 2022

Description

This refactor cleans up #23 and #26 ahead of a v0.0.2 release.

  • High-level API cleaned up to load_nwb, save_nwb, load_labelstudio, save_labelstudio
  • Basic NWB loading support
  • Add Label Studio functionality for inferring nodes.

Types of changes

  • Bugfix
  • New feature
  • Refactor / Code style update (no logical changes)
  • Build / CI changes
  • Documentation Update
  • Other (explain)

Does this address any currently open issues?

[list open issues here]

Outside contributors checklist

  • Review the guidelines for contributing to this repository
  • Add tests that prove your fix is effective or that your feature works
  • Add necessary documentation (if appropriate)

Thank you for contributing to SLEAP-IO!

❤️

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #27 (4f01858) into main (9d77d07) will decrease coverage by 0.09%.
The diff coverage is 97.09%.

@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   98.74%   98.64%   -0.10%     
==========================================
  Files          11       11              
  Lines         639      740     +101     
==========================================
+ Hits          631      730      +99     
- Misses          8       10       +2     
Impacted Files Coverage Δ
sleap_io/io/labelstudio.py 91.30% <91.52%> (+0.09%) ⬆️
sleap_io/__init__.py 100.00% <100.00%> (ø)
sleap_io/io/main.py 100.00% <100.00%> (ø)
sleap_io/io/nwb.py 100.00% <100.00%> (ø)
sleap_io/io/utils.py 100.00% <100.00%> (ø)
sleap_io/model/skeleton.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@talmo
Copy link
Contributor Author

talmo commented Nov 10, 2022

FYI: This just needs some additional tests to improve coverage before being good to go for a quick and dirty release of v0.0.2.

Future work will clean up and cover some gaps introduced here, but this gets the functionality out there.

This should be merged before #22 and #25.

@h-mayorquin
Copy link
Contributor

h-mayorquin commented Nov 11, 2022

Hi,
For the append_nwb function, you can use the io (NWBHDF5IO) as a context manager already (same for writing):

https://pynwb.readthedocs.io/en/stable/tutorials/general/file.html#reading-an-nwb-file

Curios if you know this and you are still doing it with try-except block for some reason.

@talmo talmo marked this pull request as ready for review December 13, 2022 04:45
@talmo talmo merged commit c55f64e into main Dec 13, 2022
@talmo talmo deleted the talmo/refactoring_pre_v0.0.2 branch June 23, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants