Skip to content
This repository has been archived by the owner on Sep 13, 2018. It is now read-only.

walking away from an npc while talking to it crashes client and server #44

Open
Schaefers opened this issue Apr 8, 2015 · 3 comments
Open
Labels

Comments

@Schaefers
Copy link

When starting to talk to a npc and than walking away from it makes it impossible to close the dialog and the client (in this case on Android) shows the "not logged in"-message. After trying to login again the client shows "No Gameserver found for Map the character is on".
@Ablu confirmed that the server crashed.

@Schaefers Schaefers changed the title removing from an npc while talking to it crashes the client and server removing from an npc while talking to it crashes client and server Apr 8, 2015
@Schaefers Schaefers changed the title removing from an npc while talking to it crashes client and server walking away from an npc while talking to it crashes client and server Apr 8, 2015
@Ablu
Copy link
Member

Ablu commented Apr 9, 2015

Does the client actually crash or only disconnect?

@bjorn bjorn added the bug label Apr 10, 2015
@Ablu
Copy link
Member

Ablu commented Apr 24, 2015

The critical part is fixed. The server no longer crashs now.

However it looks like the client is sending some uninitialised memory as the public id? (at least the server receives a negative number).

So what is left is to fix this undefined behaviour and close the dialoge on the clientside if we go too far away.

@bjorn
Copy link
Member

bjorn commented Apr 26, 2015

Just for reference, the fix was in commit mana/manaserv@1518b8f

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants