From 5fae4c408177db70c639d1ebd100e06bf4633085 Mon Sep 17 00:00:00 2001 From: Elena Grahovac Date: Mon, 18 Dec 2017 11:45:29 +0100 Subject: [PATCH 1/3] It is not possible to handle SIGKILL --- pkg/system/signal.go | 2 +- pkg/system/signal_test.go | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/pkg/system/signal.go b/pkg/system/signal.go index 21e5e9d..4d0aeee 100644 --- a/pkg/system/signal.go +++ b/pkg/system/signal.go @@ -60,7 +60,7 @@ func NewSignals() *Signals { interrupt: make(chan os.Signal, 1), quit: make(chan struct{}, 1), - shutdown: []os.Signal{syscall.SIGINT, syscall.SIGKILL, syscall.SIGTERM}, + shutdown: []os.Signal{syscall.SIGINT, syscall.SIGTERM}, reload: []os.Signal{syscall.SIGHUP}, maintenance: []os.Signal{syscall.SIGUSR1}, } diff --git a/pkg/system/signal_test.go b/pkg/system/signal_test.go index a797249..f27d72b 100644 --- a/pkg/system/signal_test.go +++ b/pkg/system/signal_test.go @@ -54,7 +54,6 @@ func TestSignals(t *testing.T) { shutdownSignals := signals.Get(Shutdown) verifySignal(t, syscall.SIGTERM, shutdownSignals, Shutdown) verifySignal(t, syscall.SIGINT, shutdownSignals, Shutdown) - verifySignal(t, syscall.SIGKILL, shutdownSignals, Shutdown) reloadSignals := signals.Get(Reload) verifySignal(t, syscall.SIGHUP, reloadSignals, Reload) maintenanceSignals := signals.Get(Maintenance) From 8d9089b78cc5ff36d65a37064fdd7604dafaa8b9 Mon Sep 17 00:00:00 2001 From: Igor Dolzhikov Date: Thu, 21 Dec 2017 13:16:42 +0700 Subject: [PATCH 2/3] Update bit router dependency --- Gopkg.lock | 6 +++--- Gopkg.toml | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Gopkg.lock b/Gopkg.lock index 1c8c101..c92aca9 100644 --- a/Gopkg.lock +++ b/Gopkg.lock @@ -37,8 +37,8 @@ [[projects]] name = "github.com/takama/bit" packages = ["."] - revision = "a8e9c17d8de050aec0aa8b55a507eeaa08741320" - version = "0.2.3" + revision = "2cdb1c532baced0c8c18000bc4cb66907b0dff3e" + version = "0.3.0" [[projects]] branch = "master" @@ -61,6 +61,6 @@ [solve-meta] analyzer-name = "dep" analyzer-version = 1 - inputs-digest = "cd21dc84b9fce104ffaab4872754cf3bd2b46c6ffa5bf128294af36c542d4c1d" + inputs-digest = "7fe459c48eab921817ee6ba0e5c7015c1ef663439031bea702e22a56a7258950" solver-name = "gps-cdcl" solver-version = 1 diff --git a/Gopkg.toml b/Gopkg.toml index a0f78e1..fe14562 100644 --- a/Gopkg.toml +++ b/Gopkg.toml @@ -39,4 +39,4 @@ [[constraint]] name = "github.com/takama/bit" - version = "0.2.3" + version = "0.3.0" From 285641e2a6827d35bee3fabce9c0e28bcb6b7a9e Mon Sep 17 00:00:00 2001 From: Igor Dolzhikov Date: Mon, 1 Jan 2018 19:49:55 +0700 Subject: [PATCH 3/3] Bumped version number to 0.5.1 --- Makefile | 2 +- charts/Chart.yaml | 2 +- charts/values-dev.yaml | 2 +- charts/values-stable.yaml | 2 +- docs/CHANGELOG.md | 9 ++++++++- 5 files changed, 12 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index 5efb714..0a3084b 100644 --- a/Makefile +++ b/Makefile @@ -8,7 +8,7 @@ REGISTRY?=docker.io/takama CA_DIR?=certs # Use the 0.0.0 tag for testing, it shouldn't clobber any release builds -RELEASE?=0.5.0 +RELEASE?=0.5.1 GOOS?=linux GOARCH?=amd64 diff --git a/charts/Chart.yaml b/charts/Chart.yaml index 24bd3ec..4d56d16 100755 --- a/charts/Chart.yaml +++ b/charts/Chart.yaml @@ -1,6 +1,6 @@ name: k8sapp description: A Helm charts for Kubernetes application -version: 0.5.0 +version: 0.5.1 home: https://my.domain/ sources: - https://github.com/takama/k8sapp diff --git a/charts/values-dev.yaml b/charts/values-dev.yaml index df8c087..cc5dea4 100644 --- a/charts/values-dev.yaml +++ b/charts/values-dev.yaml @@ -36,7 +36,7 @@ image: ## registry: docker.io/takama name: k8sapp - tag: 0.5.0 + tag: 0.5.1 ## Docker Registry/Hub auth secret name, always use `registry-pull-secret` if registry inside if k8s ## diff --git a/charts/values-stable.yaml b/charts/values-stable.yaml index 983af64..1192fd5 100644 --- a/charts/values-stable.yaml +++ b/charts/values-stable.yaml @@ -36,7 +36,7 @@ image: ## registry: docker.io/takama name: k8sapp - tag: 0.5.0 + tag: 0.5.1 ## Docker Registry/Hub auth secret name, always use `registry-pull-secret` if registry inside if k8s ## diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index f35808f..79b5395 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -1,7 +1,14 @@ -# Version 0.5.0 +# Version 0.5.1 [Documentation](README.md) +## Changelog since 0.5.0 + +### Codebase + +- Excluded `SIGKILL` signal from list of handled signals ([#43](https://github.com/takama/k8sapp/pull/43), [@rumyantseva](https://github.com/rumyantseva)) +- Updated dependency for BitRoute version 0.3.0 ([#45](https://github.com/takama/k8sapp/pull/45), [@takama](https://github.com/takama)) + ## Changelog since 0.4.6 ### Configuration