-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatible with non-git repositories #68
Comments
Should be a simple change. Feel free to raise a PR. |
https://docs.rs/cargo_metadata/0.19.0/cargo_metadata/ Though thinking about it, this would bind it to a repository containing a cargo project, not sure if that is wanted. 😅 |
Thanks @simonsan. Toor is designed just to find the root. If it's not a very large library we should go ahead. |
I think it's not worth it to pull in a library with 2k downloads and with the insecurity of being maintained any further, the logic is just a few LOC. https://github.com/azzamsa/toor/blob/master/src/project.rs Essentially, it looks for some hardcoded patterns in the directories, goes to the parent. I think that could be boiled down to a 3-5 LOC. That being said, you probably want to have a way to determine a repository based on the ability of the |
This is a rare case, especially when using GitHub, but there are options to use VCS other than git, e.g. Jujutsu. But
gh-workflow
relies on the git repository and git binary available heregh-workflow/src/generate.rs
Lines 37 to 42 in 11be623
Consider using other approaches to find proper root to put the workflow files. Maybe https://github.com/azzamsa/toor could be helpful
The text was updated successfully, but these errors were encountered: