Fix invalid react fragment #3597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invoking React.Fragment directly does not return a valid react element
|
Puzzled as to how this passed e2e tests, thought we had some for signing now 👀 |
Shadowfiend
added a commit
that referenced
this pull request
Aug 11, 2023
Additional fix for issues on the signing screen from #3571. ## What's Changed (since v0.45.0) * Fix invalid react fragment by @hyphenized in #3597 * v0.46.0 by @Shadowfiend in #3596 * v0.45.0 by @jagodarybacka in #3589 * Add `@testing-library/dom` to `background` by @jagodarybacka in #3588 * Modify Hardhat cache config by @michalinacienciala in #3591 * Revolintion: Apply most of the `@thesis-co/eslint-config` lint styling to the extension by @Shadowfiend in #3571 * Release Checklist Update: Added Flashbots by @andreachapman in #3592 * DAppstrosities: Fix a few observed dApp connection issues by @Shadowfiend in #3593 **Full Changelog**: v0.45.0...v0.46.0 Latest build: [extension-builds-3598](https://github.com/tahowallet/extension/suites/14964619550/artifacts/853742841) (as of Wed, 09 Aug 2023 22:44:33 GMT).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing
TransactionDataPanelSwitcherto fail, blocking transaction signing.Latest build: extension-builds-3597 (as of Wed, 09 Aug 2023 15:51:03 GMT).