Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The decode logic should be done on Cows instead of slices #336

Closed
stevenroose opened this issue Oct 26, 2021 · 1 comment
Closed

The decode logic should be done on Cows instead of slices #336

stevenroose opened this issue Oct 26, 2021 · 1 comment
Labels
encoding Issues related to support of various encodings of the XML documents enhancement help wanted optimization Issues related to reducing time needed to parse XML or to memory consumption

Comments

@stevenroose
Copy link

Just like I did #330 for unescaping, the same should be done for decoding. The Cow's that are currently returned make very little sense, because they usually borrow into ephemeral data so they will always eventually have to be converted into owned data. I'm thinking of having some kind of Bytes-based implementation that might allow us to not have to re-allocate so often when we already have a Cow::Owned.

@stevenroose stevenroose changed the title The decode logic should be done one Cows instead of slices The decode logic should be done on Cows instead of slices Oct 26, 2021
@Mingun Mingun added enhancement optimization Issues related to reducing time needed to parse XML or to memory consumption encoding Issues related to support of various encodings of the XML documents help wanted labels May 21, 2022
@dralley
Copy link
Collaborator

dralley commented Jul 29, 2022

#158 will address this

@dralley dralley closed this as completed Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
encoding Issues related to support of various encodings of the XML documents enhancement help wanted optimization Issues related to reducing time needed to parse XML or to memory consumption
Projects
None yet
Development

No branches or pull requests

3 participants