Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve window search #2

Open
tadly opened this issue Jul 19, 2017 · 4 comments
Open

Improve window search #2

tadly opened this issue Jul 19, 2017 · 4 comments

Comments

@tadly
Copy link
Owner

tadly commented Jul 19, 2017

Currently only WM_NAME will be taken into account while identifying a window.
A unique match is not guarantied and falling back to the first match out of the whole set is likely to be wrong.

I'd like to expand the search by at least WM_CLASS for additional filtering.

@rotsix
Copy link

rotsix commented Jul 21, 2017

Yep, if I were you, I would add id or instance or even title with a regex matching O:)

@tadly
Copy link
Owner Author

tadly commented Jul 21, 2017

title is what will be used right now (probably should change the cli naming for that).

I'm still fiddling with xdotool search but it's just not doing what I'd expect it to.
e.g. open a nautilus window.
class will be Nautilus while instance will be nautilus.

Doing xdotool search --class 'nautilus' I'd expect no mach, yet I get one.

I just always get more results than I'd expect and haven't found a proper/nice way of doing it :/

@tadly
Copy link
Owner Author

tadly commented Aug 31, 2017

I started digging again and it's actually a somewhat strange search implementation within xdotool which doesn't allow to combine class, instance and title searches with different search-terms.

There's an issue where I added my 2 cents. Let's see where this'll go.

Until than I'll try and work around it using multiple search requests somehow :)

@tadly
Copy link
Owner Author

tadly commented Aug 31, 2017

This took way to long to implement ':D
But here we go (I hope), better search -> 665c0bd

I'll still leave that one open as the implementation is just a workaround and I want to see what xdotool will do as he isn't happy with his implementation either :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants