Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 4.9.8 is broken #14

Open
elios264 opened this issue Mar 5, 2020 · 3 comments · May be fixed by #16
Open

Version 4.9.8 is broken #14

elios264 opened this issue Mar 5, 2020 · 3 comments · May be fixed by #16

Comments

@elios264
Copy link

elios264 commented Mar 5, 2020

.b--black { border-color: undefined; }

it also returns undefined when building from source, whereas I can with 4.9.6,

and since you removed a bunch of colors it no longer match with what is documented in :
https://tachyons.io/docs/table-of-styles/

@DrSpez
Copy link

DrSpez commented Mar 17, 2020

I get the same issue with undefined
Seems like _variables.css is not being correctly imported on build
Also minified css turns out to be identical to original one

@allancole
Copy link

Yeah, I’m having the same exact issue.

It looks like the tachyons-build-css tool is referencing an older version of postcss-css-variables:

"postcss-css-variables": {
"version": "0.8.1",
"resolved": "https://registry.npmjs.org/postcss-css-variables/-/postcss-css-variables-0.8.1.tgz",
"integrity": "sha1-pS5e8aLrYzqKT1/ENNbYXUD+cxA=",

The most recent version of postcss-css-variables is 0.17.0.

Troubleshooting

I also did some troubleshooting and when you add a fallback value to the CSS-variable, the fallback appears in the ouput. Here’s an example:

_spacing.css before compiling:

.pa0 { padding: var(--spacing-none); }
.pa1 { padding: var(--spacing-extra-small, 0.25rem); }
.pa2 { padding: var(--spacing-small); }

tachyons.css after compiling:

.pa0 { padding: undefined; }
.pa1 { padding: 0.25rem; }
.pa2 { padding: undefined; }

This make me feel like this is an incorrect options issue in the tachyons build tool itself.

Hoping @mrmrs or @johno can chime in on this sometime soon :-)

@allancole allancole linked a pull request May 10, 2020 that will close this issue
@allancole
Copy link

Did some digging and figured out what the problem is and solved it in #16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants