-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can we convert this in to ServerResponseError.from_response exception instead of NonXMLResponseError #1472
Comments
Can you expand on what you're trying to do and why you think that would be helpful? from tableauserverclient.server.endpoint.exceptions import TableauError |
It's improves the readability and parsing of information, as ServerResponseError. |
The issue is if the server doesn't return XML, it can't be parsed into a ServerResponseError. Hence: NonXMLResponseError. |
but I have seen it responding xml response but data is not parsed. |
Can you post a reproducible example of what you are trying when you get the error, as well as the error message returned? |
This is happening when personal token is wrong and Server authentication failed to Sign in. |
Closes tableau#1472 This makes sign in failures their own class of exceptions, while still inheriting from NotSignedInException to not break backwards compatability for any existing client code. This should allow users to get out more specific exceptions more easily on what failed with their authentication request.
Closes tableau#1472 This makes sign in failures their own class of exceptions, while still inheriting from NotSignedInException to not break backwards compatability for any existing client code. This should allow users to get out more specific exceptions more easily on what failed with their authentication request.
Closes tableau#1472 This makes sign in failures their own class of exceptions, while still inheriting from NotSignedInException to not break backwards compatability for any existing client code. This should allow users to get out more specific exceptions more easily on what failed with their authentication request.
Closes tableau#1472 This makes sign in failures their own class of exceptions, while still inheriting from NotSignedInException to not break backwards compatability for any existing client code. This should allow users to get out more specific exceptions more easily on what failed with their authentication request.
It would be helpful if ServerResponseError.from_response is implemented on line 173 instead NonXMLResponseError.
server-client-python/tableauserverclient/server/endpoint/endpoint.py
Line 173 in 4259316
The text was updated successfully, but these errors were encountered: