Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promise returned by changeParameterValueAsync/applyFilterAsync/selectMarksByValueAsync resolved before the changes are fully applied #66

Open
florent-guinard opened this issue Aug 7, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@florent-guinard
Copy link

Hi,

The following functions of the Embedding API:

all return a Promise: we expect this Promise to be resolved when the corresponding action is applied on the embedded Viz.
In practice, we regularly notice that the Promise is resolved before the embedded Viz is fully updated. When this happens it can be as short as a 0.5s delay and as long as 2-3 seconds based on the size of the embedded Viz.

This causes issues with our usecases: for example, we take screenshots of the browser after applying those actions or record a video of the action being applied, and we have to add a manual 2/3 seconds delay after each action to make sure that the embedded Viz was fully updated.
This is not practical since it delays all of our interactions with the embedded Viz, and we have no guarantee that it will work for 100% of our embedded Vizs.

Would it be possible to change those Promises so that they are resolved after the embedded Viz is fully loaded, or add something in those functions to have this behavior ? Thanks !

@stephendeoca
Copy link

Hi @florent-guinard, our team is currently investigating this.

@stephendeoca stephendeoca self-assigned this Aug 7, 2023
@bcantoni bcantoni added the bug Something isn't working label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants