Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing setter on GelfHandler for multiple additional fields #125

Open
goedtim opened this issue Jul 11, 2018 · 0 comments
Open

Missing setter on GelfHandler for multiple additional fields #125

goedtim opened this issue Jul 11, 2018 · 0 comments

Comments

@goedtim
Copy link

goedtim commented Jul 11, 2018

We are using the GelfHandler as part of a JBoss EAP6 application and create/configure it as a custom handler in the JBoss configuration. Furthermore we need to provide multiple additional fields.

Current issue is, that JBoss inspects the Handler class and for any property provided in the configuration, it expects a matching setter. Example property graylogHost needs a setter setGraylogHost().

For all supported properties there is a matching setter, also for a single additional field, but not for multiple additional fields. Also, JBoss configuration does not allow repeating the same property multiple times. So we would need a setter setAdditionalFields(String fields) with a parsing logic similar to what is currently done in the constructor.

I could provide a fix, just want to discuss here if that's fine or if I am on a wrong track. Also, if I provide a fix, how long would it take for a new release as we would probably not install custom build software in our PROD environment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant