Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate to use a Trait or common ancestor for "patch-add" / "patch-remove" command which are very similar #13

Open
szeidler opened this issue Aug 23, 2019 · 0 comments
Open

Evaluate to use a Trait or common ancestor for "patch-add" / "patch-remove" command which are very similar #13

szeidler opened this issue Aug 23, 2019 · 0 comments

Comments

@szeidler
Copy link
Owner

Maybe this dialog (and following) should be put as a Trait so can be shared between the two patch-add and patch-remove classes?
Or else have a common ancestor like PatchFileManipulatorAbstractCommand ?

Having a common ancestor could also help for adding/removing the patch with sharing all the options, because basically the two commands are very very similar.

Originally posted by @esolitos in #12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@szeidler