-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Measuring memory footprint #76
Comments
@maltempi Thank you for pointing out the issue. I also noticed the slow-down on the first execution, and the potential violation seems caused by The codebase is organized as follows.
The memory-managing modules are the problem, obviously. Currently, predictor, Huffman encoder, and outliers are 3 classes that handle memory separately with certain assumptions corresponding to the input size. As of now, it is no longer needed as the improved algorithm can simplify the intermediate data description. Hence, by removing the OOD redundancy in modules, this issue can be resolved (I am working on this now). The update/fix will first be pushed to https://github.com/szcompressor/cuSZ/tree/canary when ready. |
Hello, Has this issue been solved ? Thanks |
Hi @jtian0 , We want to start exploring new compressors for our research work, do you know if the "memory leak" issue still happens? Thank you in advance! -- Edit I added an endless loop into example/src/demo_capi.cu_hip.cc and in a few seconds it breaks due OOM. while ( true ) {
f<float>(std::string(argv[1]));
} |
@maltempi I am sorry for the delay. The issue has been initially resolved in c3c3a74. I quickly tested the command line locally, using Previously, the C wrapper caused the issue, but the underlying memory management is not robust, either. |
@maltempi My colleague had a conversation with your team during SC '23 regarding the compression research, which I missed. Afterward, I could not find your contact information on the SC website or your lab's website. Can you please send an email to tian.jn09+dev AAATTT gmail.com at your convenience? Thank you. |
Hi!
I am executing some tests with cusz API and measuring the memory footprint and I found something interesting and I'd like to share with the community -- and I'd be more than happy to hear your thoughts about that.
After compressing and decompressing, cusz seems leaving a residue of allocated memory. In my code example, I'm doing 10 iterations of compression and decompression on the same input.
In the chart below, we can see a peak of memory usage during compression and decompression (as expected). After decompression, cusz frees memory and my client code example also frees all allocated memory and the memory consumption decreases. However, notice that memory consumption does not get back to the original state and for each iteration, it leaves a little of memory. I'd say it might suggest a memory leak.
Thank you very much!
The text was updated successfully, but these errors were encountered: