Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matching does not consider Maximum helpers per requesting person setting #10

Open
jensschuppe opened this issue Mar 30, 2020 · 2 comments
Open

Matching does not consider Maximum helpers per requesting person setting #10

jensschuppe opened this issue Mar 30, 2020 · 2 comments
Labels
enhancement New feature or request needs funding

Comments

@jensschuppe
Copy link
Contributor

According to @bjendres, this is not yet implemented, although the configuration setting exists.
@jensschuppe jensschuppe added the enhancement New feature or request label Mar 30, 2020
@jensschuppe jensschuppe added this to the 1.1 milestone Mar 30, 2020
@bjendres
Copy link
Member

Implementation would be quite some work, because you'd also have to extend the scoring system. I'd re-visit that when somebody requests it.

@jensschuppe In the meantime, should we disable the setting to avoid confusion?

@bjendres bjendres removed this from the 1.1 milestone Mar 30, 2020
jensschuppe added a commit that referenced this issue Mar 30, 2020
@jensschuppe
[#10] remove setting for max helpers per help request, since it is no…
bfd2aab 
…t yet implemented
jensschuppe added a commit that referenced this issue Mar 30, 2020
@jensschuppe
[#10] Provide setting for max helpers per help request
48f1a28
@jensschuppe
Copy link
Contributor Author

I removed the setting on the master branch and re-added it in branch issue/10.

Implementation would need a COUNT() of relationships in the WHERE clause within CRM_Mutualaid_Matcher::getOpenRequestsQuery().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request needs funding
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bjendres @jensschuppe