Don't expose ECK entities without subtypes to afform #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensschuppe
added
enhancement
colemanw
reviewed
Nov 14, 2024
| 'type' => 'primary', | ||
| 'defaults' => '{}', | ||
| ]; | ||
| if ([] !== \CRM_Eck_BAO_EckEntityType::getSubTypes($entityType['name'])) { |
There was a problem hiding this comment.
This could be simplified & commented like
Suggested change
| if ([] !== \CRM_Eck_BAO_EckEntityType::getSubTypes($entityType['name'])) { | |
| // Don't expose ECK entities without subtypes; they cannot be saved without a value for the required `subtype` field | |
| if (\CRM_Eck_BAO_EckEntityType::getSubTypes($entityType['name'])) { |
There was a problem hiding this comment.
I recently switched to type-safe comparisons whenever possible, as that makes code more obvious for reading and also safer for static code analysis (our current PHPStan config would complain with a boolean comparison for an array method result).
As for the comment, I think I have to agree that subtypes being required doesn't seem obvious enough, so yeah, let's add that.
|
OK looks good to merge IMO |
jensschuppe
added
status:fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #138.
ECK entity types without a subtype should not be made available to FormBuilder as submitting entity forms for entities without a subtype will silently fail.