New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent infinite loop when tokens are used in headers or footers #72

Open

dontub wants to merge 1 commit into master from prevent-infite-loop

Contributor

dontub commented Nov 8, 2024

Fixes #71.

Note: setValue() replaces all variables in the document since 0.13.0 (PHPOffice/PHPWord#618) so it's not necessary to execute it in a loop.

I'll add another issue regarding replacement of variables in footers and headers.

systopia-reference: 27046


          Prevent infinite loop when tokens are used in headers or footers

3a43630

Contributor Author

dontub commented Nov 13, 2024

Strange that Assert\Assertion is not found in this test and only affects one container. Though this is independent of this change.

dontub requested a review from jensschuppe

November 15, 2024 13:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet