Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only process relevant parts inside an OOXML archive when replacing tokens #13

Open
jensschuppe opened this issue Dec 8, 2021 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@jensschuppe
Copy link
Contributor

Currently, the LocalUnoconv renderer processes all files found inside the ZipArchive, including metadata files, while only the document itself and parts containing user text (such as footnotes, footers, etc, see OOXML anatomy) should be necessary to be processed. Ignoring all other parts would increase performance of the rendering process.

@jensschuppe
Copy link
Contributor Author

cc46f77 filters for XML assets only, as a first step, since binary assets (e.g. images) have shown to become damaged when run through token replacement. This should also reduce conversion time for files with many or large media assets.

@jensschuppe
Copy link
Contributor Author

This should be either further improved by filtering for really relevant XML files only or be removed in favor of PHPWord template processing. Currently, regexp replacement is only done when the Use PHPWord macros for Live Snippet tokens option is off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants