Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Email validation regex is not matching '+' in the user part #35

Open
d1ss0nanz opened this issue Sep 11, 2019 · 3 comments
Open

Email validation regex is not matching '+' in the user part #35

d1ss0nanz opened this issue Sep 11, 2019 · 3 comments
Labels
bug

Comments

@d1ss0nanz
Copy link

[email protected] isn't accepted as valid email.
@bjendres
Copy link
Member

fair point. @d1ss0nanz would you care to create a PR?

@bjendres bjendres added the bug label Sep 11, 2019
@d1ss0nanz
Copy link
Author

Sure. Any thoughts on using filter_var instead of a custom regex?

@bjendres
Copy link
Member

Seeing that this project is all about a minimal attack vector: do you think filter_var is safer than preg_match?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bjendres @d1ss0nanz