Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When whitelisting for specific IP addresses a long list might be needed #15

Open
ErikHommel opened this issue Jul 20, 2017 · 1 comment
Assignees

Comments

@ErikHommel
Copy link
Collaborator

No description provided.

@artfulrobot
Copy link

(Just starting to look at this project for first time, please excuse if I've misunderstood anything)

Would this be acceptable though?

$preset_1 = [ 'contact' => [ 'getsingle' => [ ... ] ], ... ];
$rest_allowed_actions => [
    '1.2.3.4' => $preset_1, 
    '2.3.4.5' => $preset_1,
    '3.4.5.6' => [ 'otherEntity' => [ 'someaction' => ... ] ] + $preset_1,
];

Although I think it would be better to reference the function that inspects this array in a variable so that it can be overridden easily if someone has particular requirements that might be more efficiently described without this array format. i.e. move to a container/service provider model for the thing that determines whether the (rest) request is allowed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants