Skip to content
This repository has been archived by the owner on Nov 8, 2018. It is now read-only.

Ambiguous contact image shown in circle of trust #424

Open
ashu-dadhich opened this issue Mar 10, 2017 · 11 comments
Open

Ambiguous contact image shown in circle of trust #424

ashu-dadhich opened this issue Mar 10, 2017 · 11 comments
Assignees

Comments

@ashu-dadhich
Copy link

ashu-dadhich commented Mar 10, 2017

List of issues

  • Acc to ITU-T in the recommendation E.164, which specifies that the entire number should be 15 digits or shorter.
    http://en.wikipedia.org/wiki/Telephone_number
    So I propose the length of number be limited to 15 digits because if a user puts a 100 dig number the whole layout messes up.

  • On entering numbers in certain range some irrelevant images are picked up. Attaching a snap of it below.

  • This one is a suggestion: What if the user wants to change only one number instead of more than one?
    Therefore there should be a click listener on the contacts icon on the main screen of circle of trust so he/she can change the contact without going to the edit contact screen.
    image

@madhavrathi
Copy link

madhavrathi commented Mar 10, 2017

can i work on this or you already have started working on it ?

@sandarumk
Copy link

sandarumk commented Mar 10, 2017

I think two of the three issues are reported before. The layout issue is reported by a GCI student. Can you go through the list and check whether this is the same?
Can you explain the second point further?
The click listener on the contacts has also been suggested before. (See closed issues). We do not need that functionality as of now.

@ashu-dadhich
Copy link
Author

I guess the issue you were referring for my first issue is #321 but there is a slight difference in my issue and his:
Difference
#321 was related to dealing with length of contacts which are too long.
Whereas mine deals with limiting length of contact number to 15.

**Solution for #321 **
Since this one is unsolved yet I propose a solution that if the contact length exceeds a specified length we can shorten it just like abbreviations.
eg: Lava Institute Of Advanced Technology can be transformed to LIOAT
So can I work on both of them?
Thank you

@ashu-dadhich
Copy link
Author

Explanation for Second Issue
What I found was when I was entering a number between 0-5. Lets say 5 as contact number some ambiguous contact image was replacing the default contact image as you can see in the screenshot.
Should I go ahead and find the find the root cause for this behaviour?
Thank you

@ashu-dadhich
Copy link
Author

can I proceed @sandarumk ?

@sandarumk
Copy link

sandarumk commented Mar 14, 2017

Did you identify the reason for the second issue?

@ashu-dadhich
Copy link
Author

Thank you for replying.
Yes, The problem is caused because the the contact number is being treated as an index.
eg
Let's Suppose the fifth contact in your contact list contains an image of the contact then if you enter a number below five the image of the contact would be displayed instead of the default image.
Shall I proceed on this?

@sandarumk
Copy link

Yes go ahead with the second one.

@sandarumk
Copy link

Although these bugs are in a single screen, they represent three separate issues. In future, please report them as separate issues and have meaningful titles so that anyone can get the idea of the issue by reading the title only.

@ashu-dadhich
Copy link
Author

Yeah sure.

@ashu-dadhich ashu-dadhich changed the title Issues in Circle of Trust. Ambiguous contact image shown in circle of trust Mar 15, 2017
@ashu-dadhich
Copy link
Author

ashu-dadhich commented Mar 15, 2017

Have solved the second one should the first one be solved too?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

3 participants