Set link args in build script #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crawfxrd
force-pushed
the
build-script
branch
from
11399f9 to
6369ec4
Compare
While working on converting our UEFI images to a workspace I found that the cargo configuration file cannot be used. `config.toml` is a *project*-level configuration. It will only be read from the current directory and up, and not in: - package directories in a workspace - package directory when `--manifest-path` is used Use `build.rs` instead, which will be executed before the package is built and only apply the flags for the specific package. Ref: https://doc.rust-lang.org/cargo/reference/config.html#hierarchical-structure Ref: https://doc.rust-lang.org/cargo/reference/build-scripts.html Signed-off-by: Tim Crawford <[email protected]>
crawfxrd
force-pushed
the
build-script
branch
from
6369ec4 to
01dcb2d
Compare
jackpot51
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on converting our UEFI images to a workspace I found that the cargo configuration file cannot be used.
config.tomlis a project-level configuration. It will only be read from the current directory and up, and not in:--manifest-pathis usedUse
build.rsinstead, which will be executed before the package is built and only apply the flags for the specific package.Ref: https://doc.rust-lang.org/cargo/reference/config.html#hierarchical-structure
Ref: https://doc.rust-lang.org/cargo/reference/build-scripts.html
Test
--verboseadded to cargo command and verify linker scripts are still applied.file target/x86_64-unknown-uefi/release/system76_firmware_setup.efistill reports binary as EFI boot service driver.