Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

Calls changing incorrectly defined #133

Open
marcoscaceres opened this issue Jun 17, 2013 · 3 comments
Open

Calls changing incorrectly defined #133

marcoscaceres opened this issue Jun 17, 2013 · 3 comments
Milestone

Comments

@marcoscaceres
Copy link
Contributor

The spec says:

Whenever a call is added to or removed from the calls array, the user agent MUST queue a task to fire an event named callschanged.

The above should be defined in terms of the underlying telephony system - not in terms of something changing in the calls array.

@zolkis
Copy link
Contributor

zolkis commented Jun 17, 2013

Actually it is referring to the change in the 'calls' array only. New calls get signaled through 'onincoming', finished calls through 'ondisconnected'. 'calls' could be a synchronous method returning a sequence of TelephonyCall objects, at least my implementation does that.

@marcoscaceres
Copy link
Contributor Author

I agree, we need to change call to a sequence. If onincoming handles an added call, and ondisconnected handles a call vanishing (I know, crappy word... bare with me), then callschanged seems redundant.

@zolkis
Copy link
Contributor

zolkis commented Jun 21, 2013

What if the call disconnects, and you have it in the sequence (since it is copied by value), so it's invalid? I like more the idea of having exactly one call object per call, referenced.

marcoscaceres added a commit to marcoscaceres/telephony that referenced this issue Jun 28, 2013
The changes are not longer related to the array, but to the telephony
service.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants