You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.
The groupBy can just be added to FilterOption because fileterOptions is required (and just give groupBy a sensible default like "subject"). Also, it looks like groupBy needs it's own enum!
For messaging.delete(), the API should just guarantee that message and conversation and conversations have unique ids. If it can't do that for whatever reason, then again just use the enum:
The spec defines the following methods that all practically do the same thing - the only different is in the method name:
findMessages could just become "find" if we added an "enum CommunicationType { "message", "conversation" } ".
So:
The groupBy can just be added to FilterOption because fileterOptions is required (and just give groupBy a sensible default like "subject"). Also, it looks like groupBy needs it's own enum!
For messaging.delete(), the API should just guarantee that message and conversation and conversations have unique ids. If it can't do that for whatever reason, then again just use the enum:
The same with markAsRead():
And, like I said, if we make the id's unique for conversations and messages, then it makes the API even simpler.
The text was updated successfully, but these errors were encountered: