Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write single file snapshots immediately, even with python-xdist #841

Open
rassie opened this issue Dec 13, 2023 · 0 comments
Open

Write single file snapshots immediately, even with python-xdist #841

rassie opened this issue Dec 13, 2023 · 0 comments
Labels
feature request New feature or request performance

Comments

@rassie
Copy link

rassie commented Dec 13, 2023

Is your feature request related to a problem? Please describe.

In #535 and adjacent issues, a compatibility layer with python-xdist has been implemented (thanks by the way!). One problem remains though: the snapshots are now collected in memory to be written at once at the end of the session. This is sensible for Amber files with multiple results, however, with large snapshots (e.g. images/screenshots), the memory footprint rises fast -- and there is probably no need to delay snapshot writing for anything derived from SingleFileSnapshotExtension, since there is only once process/thread writing to that single file.

Describe the solution you'd like

Restrict in-memory snapshot collection to certain extensions, e.g. by providing a flag and setting this flag appropriately on built-in extensions.

@noahnu noahnu added feature request New feature or request performance labels Feb 3, 2024
@noahnu noahnu added this to Syrupy Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request performance
Projects
Status: No status
Development

No branches or pull requests

2 participants