Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feedrate override with cncjs #273

Open
kbex1 opened this issue Sep 24, 2021 · 1 comment
Open

feedrate override with cncjs #273

kbex1 opened this issue Sep 24, 2021 · 1 comment

Comments

@kbex1
Copy link

kbex1 commented Sep 24, 2021

i think i might be missing something here,
i'm running the latest firmware on a tinyG v8 (Edge-449.01) and the lastest cncjs 1.9.22.
with JSON enabled {sso:n} is not recognized, and is not mentioned in the docs.
it is not supported anymore ? (or the more likely scenario i'm missing some configuration )

Thanks

@kbex1
Copy link
Author

kbex1 commented Sep 26, 2021

after some digging i found the the spindle code that supports the feedrate is only on branch edge 0.98 and was never merged into the other "edge" branch master-449.

@aldenhart is there something i should be aware of before i merge the 0.98 spindle code that supports the federate override to the master-449 branch ?

i can test it with my machine but before i solve the merge conflicts for the "master-449" branch and such, is there a reason just taking the code from edge-0.98 for the spindle.h and spindle.c and compiling shouldn't work? it seems there was only one commit for it in 444.18 on the edge-0.98 branch.

thanks
kfir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant