Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated dependency: device_info_plus #2167

Open
mauriziopinotti opened this issue Nov 13, 2024 · 2 comments
Open

Outdated dependency: device_info_plus #2167

mauriziopinotti opened this issue Nov 13, 2024 · 2 comments
Labels
follow-up scheduled Follow-up scheduled pdf viewer PDF viewer component

Comments

@mauriziopinotti
Copy link

mauriziopinotti commented Nov 13, 2024

Bug description

syncfusion_flutter_pdfviewer >=26.1.42 depends on device_info_plus ^10.1.0

Steps to reproduce

  1. Create an example app
  2. Add dependency on latest device_info_plus: ^11.1.1
  3. Run flutter pub get

Code sample

Code sample
dependencies:
  flutter:
    sdk: flutter

  device_info_plus: ^11.1.1

Screenshots or Video

Screenshot demonstration

image

Stack Traces

Stack Traces
Because syncfusion_flutter_pdfviewer >=26.1.42 depends on device_info_plus ^10.1.0 and easyhour_app depends on device_info_plus ^11.1.1, syncfusion_flutter_pdfviewer >=26.1.42 is forbidden.
So, because easyhour_app depends on syncfusion_flutter_pdfviewer ^27.1.48, version solving failed.

On which target platforms have you observed this bug?

Android, iOS, Web

Flutter Doctor output

Doctor output
[✓] Flutter (Channel stable, 3.24.4, on Ubuntu 24.10 6.11.0-9-generic, locale en_US.UTF-8)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0-rc2)
[✓] Chrome - develop for the web
[✓] Linux toolchain - develop for Linux desktop
[✓] Android Studio (version 2024.2)
[✓] IntelliJ IDEA Ultimate Edition (version 2024.2)
[✓] VS Code (version 1.95.2)
[✓] Proxy Configuration
[✓] Connected device (2 available)
[✓] Network resources

• No issues found!
@mauriziopinotti mauriziopinotti changed the title Outdated dependency: Outdated dependency: device_info_plus Nov 13, 2024
@VijayakumarMariappan VijayakumarMariappan added pdf viewer PDF viewer component open Open labels Nov 14, 2024
@KrithigaPerumal
Copy link

Hi @mauriziopinotti,

We are checking the feasibility of upgrading the device_info_plus package in syncfusion_flutter_pdfviewer. We need to ensure that upgrading to the newer version will not affect the functionality of the SfPdfViewer widget. We will let you know once the analyzation is completed.

Regards,
Krithiga Perumal.

@Deepak1799 Deepak1799 added follow-up scheduled Follow-up scheduled and removed open Open labels Nov 15, 2024
@mauriziopinotti
Copy link
Author

Hi @mauriziopinotti,

We are checking the feasibility of upgrading the device_info_plus package in syncfusion_flutter_pdfviewer. We need to ensure that upgrading to the newer version will not affect the functionality of the SfPdfViewer widget. We will let you know once the analyzation is completed.

Regards, Krithiga Perumal.

Sure, thanks.

The only breaking change is fluttercommunity/plus_plugins#3254 so if you are not using the deviceMemory no changes are required on your side. And if you are using the deviceMemory field the migration should be pretty straightforward as it just changed from int to double.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
follow-up scheduled Follow-up scheduled pdf viewer PDF viewer component
Projects
None yet
Development

No branches or pull requests

4 participants