Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Job doesn't fail when there are errors #1

Closed
johnbillion opened this issue Dec 8, 2024 · 1 comment
Closed

Job doesn't fail when there are errors #1

johnbillion opened this issue Dec 8, 2024 · 1 comment

Comments

@johnbillion
Copy link

In johnbillion/plugin-infrastructure#34 I've switched from using octoscan directly to using the synacktiv/action-octoscan action. The action detects errors and successfully submits the SARIF to CodeQL, but the job itself doesn't fail. The workflow therefore shows as passing. Here's the workflow run: https://github.com/johnbillion/plugin-infrastructure/actions/runs/12222540398/job/34092971878.

Is this expected?
@johnbillion
Copy link
Author

This needs to be configured via Rulesets. Nothing specific to this action.

@johnbillion johnbillion closed this as not planned Won't fix, can't repro, duplicate, stale Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johnbillion