You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.
While doing the tab/group improvements, my eye's catched some options which I don't believe are usefull for the admin (at least not in the current way). I even believe most of them never will be usefull. First of all, words I don't think the admin understands: Controller, arguments, route.
If you then look closer at the options, the Variable pattern doesn't make any sense for the admin. What will change if the admin would put something in that text field? What's then passed to the "controller" (whatever that might be) if the controller defined those "arguments"?
What can the admin change with this? I think nothing.
The three checkboxes are about things I believe the admin understands (except that we should change "route" to "path" or "url" imo).
But then, if an admin checks format pattern, what is going to be changed? Does it mean the URL has to end with .html? If we want that, it should probably be a global option (it isn't very nice to edit every route in a website to enable/disable this).
The trailing slash is something that should be handled by the router itself imo. It's something the program has to care about, not the admin.
The Compiler class setting is the most cryptic of them all. Even I don't really know what it does. And if I know it, it would still not be usefull as it's just a plain text field. How do I know which compiler classes are available? I think this is an option that should only be provided to the developer.
At last, there are Controller and Template defaults. The first one belongs to the same group as the Compiler class imo. The Template class can be very usefull, it would allow the admin to change the theme for a page. However, we don't have anything about theming in our admin (we should maybe create a CmfThemingBundle). In the current way, there is no way to know what you can input in this field and what the page is going to look like in that case.
These are my thoughts about the routing admin, I would love to discuss this and see which options we can remove and what we can improve (e.g. adding a global settings page, a CmfThemingBundle, etc.)
The text was updated successfully, but these errors were encountered:
moved from symfony-cmf/routing-bundle#285
While doing the tab/group improvements, my eye's catched some options which I don't believe are usefull for the admin (at least not in the current way). I even believe most of them never will be usefull. First of all, words I don't think the admin understands: Controller, arguments, route.
If you then look closer at the options, the Variable pattern doesn't make any sense for the admin. What will change if the admin would put
something
in that text field? What's then passed to the "controller" (whatever that might be) if the controller defined those "arguments"?What can the admin change with this? I think nothing.
The three checkboxes are about things I believe the admin understands (except that we should change "route" to "path" or "url" imo).
But then, if an admin checks format pattern, what is going to be changed? Does it mean the URL has to end with
.html
? If we want that, it should probably be a global option (it isn't very nice to edit every route in a website to enable/disable this).The trailing slash is something that should be handled by the router itself imo. It's something the program has to care about, not the admin.
The Compiler class setting is the most cryptic of them all. Even I don't really know what it does. And if I know it, it would still not be usefull as it's just a plain text field. How do I know which compiler classes are available? I think this is an option that should only be provided to the developer.
At last, there are Controller and Template defaults. The first one belongs to the same group as the Compiler class imo. The Template class can be very usefull, it would allow the admin to change the theme for a page. However, we don't have anything about theming in our admin (we should maybe create a CmfThemingBundle). In the current way, there is no way to know what you can input in this field and what the page is going to look like in that case.
These are my thoughts about the routing admin, I would love to discuss this and see which options we can remove and what we can improve (e.g. adding a global settings page, a CmfThemingBundle, etc.)
The text was updated successfully, but these errors were encountered: