Skip to content
This repository has been archived by the owner on Jul 22, 2022. It is now read-only.

Sortable not working #332

Closed
danielantelo opened this issue Apr 7, 2015 · 8 comments · May be fixed by symfony-cmf/sonata-phpcr-admin-integration-bundle#115
Closed

Sortable not working #332

danielantelo opened this issue Apr 7, 2015 · 8 comments · May be fixed by symfony-cmf/sonata-phpcr-admin-integration-bundle#115
Assignees
@ElectricMaxxx
Labels
bug stale

Comments

@danielantelo
Copy link

danielantelo commented Apr 7, 2015 •
edited by ElectricMaxxx
Loading

So i have a sonata_type_collection working in my symfony cmf project, it creates, updates and removes child documents correctly.

I now want to enable sortable, but when i save with the sortable flag enabled i get "NodeName property "nodeName" may not be empty in document of class..."

Is this a known issue? or am i doing something wrong.

->add(
     'someChidlren',
     'sonata_type_collection',
     array(
          'label'    => false,
          'by_reference'   => false,
          'cascade_validation' => true,
     ),
     array(
          'admin_code' => 'admin_reference_here',
          'edit'   => 'inline',
          'inline' => 'table',
           'sortable'  => 'position',
     )
)
@lsmith77 lsmith77 added the bug label Jun 17, 2015
@lsmith77 lsmith77 added this to the 2.0 milestone Jun 17, 2015
@lsmith77
Copy link
Contributor

might also need to be fixed in 1.2

@ElectricMaxxx
Copy link
Contributor

@lsmith77 @dbu do we have an example where i could test that in sandbox? Or an example where i can implement an examaple in sandbox.

@dbu
Copy link
Contributor

dbu commented Feb 3, 2017

i found no place where we would use sonata_type_collection in the sandbox (only found the definition of the type, grepping through the code). it would make sense to use it on the container block admin. (i think we had it on the slideshow block for individual slides, but thats media bundle)

@ElectricMaxxx
Copy link
Contributor

ElectricMaxxx commented Feb 3, 2017 via email

@ElectricMaxxx
Copy link
Contributor 

        if ('doctrine_phpcr' != $options['sonata_field_description']->getAdmin()->getManagerType() || !$options['sonata_field_description']->getOption('sortable')) {
            return;
        }

sounds like the eventlistener to fill up data isn't registered for sortable

@ElectricMaxxx ElectricMaxxx mentioned this issue May 1, 2017
Open
2 tasks
@ElectricMaxxx ElectricMaxxx self-assigned this May 1, 2017
@SonataCI SonataCI removed the wip/poc label May 1, 2017
@ElectricMaxxx
Copy link
Contributor

I would move this bug into 2.1, ok? Priority seems not to be that high and we could even do it whil RC phase.

@ElectricMaxxx ElectricMaxxx modified the milestones: 2.1, 2.0 Jul 27, 2017
@dbu dbu removed this from the 2.1 milestone Jul 27, 2017
@dbu
Copy link
Contributor

dbu commented Jul 27, 2017

i removed the milestone completely. if nobody plans on working on it, there is no point in having it in a milestone.

@stale
Copy link

stale bot commented Jan 30, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Jan 30, 2020
@SonataCI SonataCI removed the wontfix label Jan 30, 2020
@core23 core23 added the stale label Feb 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ElectricMaxxx ElectricMaxxx

Labels
bug stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] container block symfony-cmf/sonata-phpcr-admin-integration-bundle
6 participants
@dbu @lsmith77 @ElectricMaxxx @core23 @danielantelo @SonataCI