Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling #91

Open
rmsint opened this issue Feb 25, 2014 · 1 comment
Open

Improve error handling #91

rmsint opened this issue Feb 25, 2014 · 1 comment
Labels
Milestone

Comments

@rmsint
Copy link
Contributor

rmsint commented Feb 25, 2014

Examples:

  • the upload service uses a media root path. If it does not exist the upload of an image will fail because the parent can not be found.
  • the cmf_create.persistence.phpcr.image.basepath and cmf_media.persistence.phpcr.media_basepath can mismatch, we should check that these are indepent and have no relation. However media-bundle services that get different root paths injected can also cause an issue. See Image upload error symfony-cmf#186

When and where to throw an error to notify the developer of this?

Maybe validate the configuration, so the developer directly knows if the configuration is not correct. Or do some extra checks in the constructor of some services?

@dbu
Copy link
Member

dbu commented Apr 4, 2014

not sure if there can not be use cases where people have different default paths, and extra services - so simply considering this an error sounds not good.

@ElectricMaxxx ElectricMaxxx added this to the 2.0 milestone Jul 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants