-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP elfinder volume driver #28
Comments
Will have a look. We also need to check it later with #27 for Create. |
@rmsint Thanks I hope I didn't reinvent the wheel to many times here, kind of losing oversight at this point. Will try and get back on track with this after the weekend. |
Have looked at it but not very thorough due to illness, some remarks/ ideas/ questions so far:
Also did some tests with |
Rebased on latest master, added configuration, cleaned up the code a bit and checked and fixed some features. Also disabled: extract, archive, rename and resize. Renaming can be enabled again once we find and fix the error it causes. Also reverted the size and contentType of the File to be persisted. Otherwise ``PHPCRDriver::_mkfile` returned an error. If we investigate and find the error the change can be added again. |
if this is now basically working, even without all optional features, i think we should merge it into master. wdyt? regarding cropping and resizing, that sounds like going out of scope to me, we already have imagine to serve images with a specific filter. this would be better than modifying the original image. if we can't make elfinder use that, we could use imagine to implement this again. but if we can find a way to have the user specify which imagine filter he wants, that would be a more elegant. |
Yes sounds like a good plan, created PR #46 so we can comment on the code. |
can you move whatever is still relevant here to #46 or/and into a PR against the symfony-cmf-docs and close this issue please? |
yes, will move the installation to the media documentation |
See symfony-cmf/symfony-cmf-docs#251 and #46 |
I added a new branch 'elfinder' with the work on the volume driver I did so far.
Most basic functions like creating folders, uploading files, removing, moving, copy, download etc work. But because there is a lot to do still I figured it would be easier to add a branch then to do a pr.
Among the things that don't yet work are previewing, cropping/resizing and opening files in the browser. But I felt I got to a point people could try it out, review code and discuss design issues.
to run the code you have to:
The text was updated successfully, but these errors were encountered: