Merge pull request #243 from symflower/237-early-merger

Early merger for "Dump the assessments to the evaluation CSV right after running a task"

evaluate/evaluate.go

@@ -135,7 +135,6 @@ func Evaluate(ctx *Context) (assessments *report.AssessmentStore, totalScore uin
 									Logger: ctx.Log,
 								}
 								assessment, ps, err := task.Run(taskContext)
-								assessments.AddAssessmentPerTask(model, language, repositoryPath, assessment)
 								if err != nil {
 									ps = append(ps, err)
 								}
@@ -145,6 +144,7 @@ func Evaluate(ctx *Context) (assessments *report.AssessmentStore, totalScore uin
 								} else {
 									modelSucceededBasicChecksOfLanguage[model][language] = true
 								}
+								assessments.AddAssessmentPerTask(model, language, repositoryPath, assessment)
 							}
 						})
 					}
@@ -244,11 +244,11 @@ func Evaluate(ctx *Context) (assessments *report.AssessmentStore, totalScore uin
 									Logger: ctx.Log,
 								}
 								assessment, ps, err := task.Run(taskContext)
-								assessments.AddAssessmentPerTask(model, language, repositoryPath, assessment)
 								problemsPerModel[modelID] = append(problemsPerModel[modelID], ps...)
 								if err != nil {
 									ctx.Log.Printf("ERROR: Model %q encountered a hard error for language %q, repository %q: %+v", modelID, languageID, repositoryPath, err)
 								}
+								assessments.AddAssessmentPerTask(model, language, repositoryPath, assessment)
 							}
 						})
 					}

model/llm/llm.go

@@ -178,10 +178,6 @@ func (m *Model) WriteTests(ctx model.Context) (assessment metrics.Assessments, e
 	assessment[metrics.AssessmentKeyResponseCharacterCount] = uint64(len(response))
 	assessment[metrics.AssessmentKeyGenerateTestsForFileCharacterCount] = uint64(len(testContent))
 
-	if err != nil {
-		return nil, pkgerrors.WithStack(err)
-	}
-
 	testFilePath := ctx.Language.TestFilePath(ctx.RepositoryPath, ctx.FilePath)
 	if err := os.MkdirAll(filepath.Join(ctx.RepositoryPath, filepath.Dir(testFilePath)), 0755); err != nil {
 		return nil, pkgerrors.WithStack(err)