Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[monorepo] consolidation of existing repositories into /product #69

Open
0x6861746366574 opened this issue Apr 13, 2022 · 2 comments
Open
Assignees
Labels
Monorepo For all issues related to the overall monorepo.

Comments

@0x6861746366574
Copy link
Contributor

0x6861746366574 commented Apr 13, 2022

Since 2022, we've made a shift from individual repositories to three distinct monorepos for the Symbol project.

We have adopted the following structure:

  • /symbol: for everything to do with the core Symbol infrastructure, including the client (catapult), catbuffer, documentation, and SDKs.
  • /product: for everything to do with products built on top of (or around) Symbol, including our wallet, website, explorer, and miscellaneous.
  • /design: for everything related to the design team. This is carved off separately from /product due to the need for LFS.
  • /kitchen-sink: hosts all of our legacy projects are no longer maintained but need to be preserved for reference or sentimental value.

However, we still have quite a lot of work left. It would be good to close this out for April, so we can start May fresh. Here are the tasks left specifically for the product monorepo.


The following repositories should be subfolders:

wallet:

@yilmazbahadir - is this something you can work on next week with @OlegMakarenko? Also a question for @cryptoBeliever - should we put symbol-cli here, or place it in kitchen-sink?

faucet: consolidates both current faucet implementations.

explorer: consolidates both our current explorer implementation and nodewatch.

@AnthonyLaw - is this something you can work on next week with @Jaguar0625?


Once we've moved everything over, we'll pull in the big guns (cc @Wayonb) to work on the Jenkins integration and then we will have eliminated a significant chunk of our repository fatigue. 💪🏻

@0x6861746366574 0x6861746366574 added the Type: Enhancement An enhancement, new feature, or quality of life improvement. Contrast with 'cleanup'. label Apr 13, 2022
@0x6861746366574 0x6861746366574 added Monorepo For all issues related to the overall monorepo. and removed Type: Enhancement An enhancement, new feature, or quality of life improvement. Contrast with 'cleanup'. labels Apr 14, 2022
@yilmazbahadir
Copy link
Contributor

Yes, absolutely!

@yilmazbahadir - is this something you can work on next week with @OlegMakarenko?

@0x6861746366574
Copy link
Contributor Author

0x6861746366574 commented May 18, 2022

Some more clarification:

  • We'll need to make sure each PR to the product monorepo is at a minimum of 90% code coverage - ideally 95%. That includes both the desktop-wallet and mobile-wallet.
  • We should update both desktop-wallet and mobile-wallet to use the new SDK. I've created two issues to track this here and here.
  • We'll need to update both desktop-wallet and mobile-wallet to utilize shared.
  • Our documentation for the wallets will need an overhaul. I think this is something @cryptoBeliever, myself and potentially OrisDorch (if I can rope him into it) can work on.

AnthonyLaw added a commit that referenced this issue May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Monorepo For all issues related to the overall monorepo.
Projects
None yet
Development

No branches or pull requests

5 participants