Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet backup got broken file #284

Closed
postoronnii opened this issue Dec 29, 2021 · 3 comments · Fixed by #303
Closed

Wallet backup got broken file #284

postoronnii opened this issue Dec 29, 2021 · 3 comments · Fixed by #303
Assignees
@OlegMakarenko
Labels
P1 Issue Breaking defect effecting all users, Security issue, Risk to users funds

Comments

@postoronnii
Copy link

WTR:

  1. Backup existing wallet
  2. Open .pdf file

Result: the file is broken
@postoronnii postoronnii added the P1 Issue Breaking defect effecting all users, Security issue, Risk to users funds label Dec 29, 2021
@cryptoBeliever
Copy link
Contributor

cryptoBeliever commented Dec 29, 2021 •
edited
Loading

Steps:

  1. Add at least one additional account
  2. Do PDF backup (Settings -> Backup)

Result:
All pages (except first one where is correctly exported mnemonics) are presented incorrectly (without QR'codes, private keys and valid addresses)

I checked builds and looks like it was introduced in:
https://github.com/symbol/mobile-wallet/releases/tag/1.1

I assume it could be "Added backward compatibility for previous XEM Opt-in accounts"

@OlegMakarenko
Copy link
Contributor

Fixed in the: symbol/wallets-lib#4
Awaiting test and review.

@OlegMakarenko OlegMakarenko linked a pull request Jan 19, 2022 that will close this issue
fix: corrupted paper-wallet backup #297
Closed
@OlegMakarenko OlegMakarenko self-assigned this Jan 19, 2022
@OlegMakarenko OlegMakarenko linked a pull request Jan 27, 2022 that will close this issue
hotfix: fix corrupted paper-wallet backup and sdk upgrade #303
Merged
@OlegMakarenko
Copy link
Contributor

Merged into main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OlegMakarenko OlegMakarenko

Labels
P1 Issue Breaking defect effecting all users, Security issue, Risk to users funds
Projects
None yet
Milestone
No milestone
3 participants
@postoronnii @cryptoBeliever @OlegMakarenko