Fix error handling exception on initialisation #348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Work around to not change the method signature (so as to not require a major version change).
kinglozzer
approved these changes
May 31, 2022
kinglozzer
requested changes
May 31, 2022
| @@ -984,6 +984,10 @@ public function runJob($jobId) | |||
| } | |||
| } catch (\Throwable $e) { | |||
| // PHP 7 Error handling) | |||
| if ($job === null) { | |||
| // In case job hasn't loaded yet, pass in a dummy (as the error handler expects a QueuedJob) | |||
| $job = QueuedJob::singleton(); | |||
There was a problem hiding this comment.
Oops, my review was premature - QueuedJob is an interface, so this won’t work
|
The issue this PR links to was closed as fixed by #374 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #316
Work around to not change the method signature (so as to not require a major version change).