Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSSE support #228

Merged
merged 3 commits into from
Nov 2, 2022
Merged

DSSE support #228

merged 3 commits into from
Nov 2, 2022

Conversation

tri-adam
Copy link
Member

@tri-adam tri-adam commented Sep 15, 2022

Add Dead Simple Signing Envelope (DSSE) encoder/decoder, which provides a way to utilize non-PGP key material. In practice, this currently includes ECDSA, ED25519, RSA.

I'm pulling in a couple of new dependencies as part of this work:

It's worth noting that the Sigstore dependency does have a DSSE package, which uses github.com/secure-systems-lab/go-securesystemslib under the hood. I'm consciously choosing not to use it here as it's useful to have access to AcceptedKey when verifying, and it doesn't materially change the dependency tree.

@tri-adam tri-adam self-assigned this Sep 15, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2022

Codecov Report

Merging #228 (73fc07a) into main (831d6b6) will decrease coverage by 0.07%.
The diff coverage is 70.47%.

@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
- Coverage   72.61%   72.53%   -0.08%     
==========================================
  Files          34       35       +1     
  Lines        2713     2818     +105     
==========================================
+ Hits         1970     2044      +74     
- Misses        600      622      +22     
- Partials      143      152       +9     
Impacted Files Coverage Δ
pkg/integrity/dsse.go 68.68% <68.68%> (ø)
pkg/integrity/result.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tri-adam tri-adam force-pushed the dsse branch 5 times, most recently from 7756272 to 549ea0d Compare October 28, 2022 17:29
@tri-adam tri-adam marked this pull request as ready for review October 31, 2022 20:17
@tri-adam tri-adam mentioned this pull request Nov 1, 2022
Copy link
Member

@dtrudg dtrudg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. I've had a read around DSSE and am definitely in favor of using that over implementing specific X509 handling directly in SIF. Usage in sigstore, TUF, is as much of guarantee as I think we are going to get that it'll be maintained and broadly understood.

pkg/integrity/dsse.go Outdated Show resolved Hide resolved
pkg/integrity/dsse.go Show resolved Hide resolved
pkg/integrity/dsse.go Outdated Show resolved Hide resolved
@tri-adam tri-adam requested a review from dtrudg November 2, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants