-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DSSE support #228
DSSE support #228
Conversation
Codecov Report
@@ Coverage Diff @@
## main #228 +/- ##
==========================================
- Coverage 72.61% 72.53% -0.08%
==========================================
Files 34 35 +1
Lines 2713 2818 +105
==========================================
+ Hits 1970 2044 +74
- Misses 600 622 +22
- Partials 143 152 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
7756272
to
549ea0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. I've had a read around DSSE and am definitely in favor of using that over implementing specific X509 handling directly in SIF. Usage in sigstore, TUF, is as much of guarantee as I think we are going to get that it'll be maintained and broadly understood.
Add Dead Simple Signing Envelope (DSSE) encoder/decoder, which provides a way to utilize non-PGP key material. In practice, this currently includes ECDSA, ED25519, RSA.
I'm pulling in a couple of new dependencies as part of this work:
It's worth noting that the Sigstore dependency does have a DSSE package, which uses
github.com/secure-systems-lab/go-securesystemslib
under the hood. I'm consciously choosing not to use it here as it's useful to have access to AcceptedKey when verifying, and it doesn't materially change the dependency tree.