Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Powershell "y" alias decoding error. #1921

Closed
3 tasks done
Aqaao opened this issue Nov 19, 2024 · 5 comments
Closed
3 tasks done

Powershell "y" alias decoding error. #1921

Aqaao opened this issue Nov 19, 2024 · 5 comments
Labels
invalid This doesn't seem right

Comments

@Aqaao
Copy link

Aqaao commented Nov 19, 2024

What system are you running Yazi on?

Windows

What terminal are you running Yazi in?

wezterm

yazi --debug output

None

Describe the bug

Windows powershell Chinese character decoding error when use "y" command.

Minimal reproducer

start yazi via "y" alias, select a path that contains Chinese characters, then press "q" quit yazi.
图片
图片

Anything else?

Resolved via add -Encoding UTF8 arg to Powershell wrapper function's line 4.

$cwd = Get-Content -Path $tmp  -Encoding UTF8 

Maybe docs should be modified to add this arg ?

Validations

  • I tried the latest nightly build, and the issue is still reproducible
  • I updated the debug information (yazi --debug) input box to the nightly that I tried
  • I can reproduce it after disabling all custom configs/plugins (mv ~/.config/yazi ~/.config/yazi-backup)
@Aqaao Aqaao added the bug Something isn't working label Nov 19, 2024
@sxyazi
Copy link
Owner

sxyazi commented Nov 19, 2024

I have no idea of how those PowerShell things work, so as usual, I'd like somebody else to confirm this is OK


Pinging @luiz00martins, sorry to bother you, but can you please confirm if -Encoding UTF8 is OK, since you're the original author of the PowerShell wrapper ;)

@sxyazi sxyazi added the help wanted Extra attention is needed label Nov 19, 2024
@Xerxes-2
Copy link
Contributor

Can you reproduce it in PowerShell 7+?

@Aqaao
Copy link
Author

Aqaao commented Nov 21, 2024

Can you reproduce it in PowerShell 7+?

I installed PowerShell 7 , it does not have this issue, error only occurs in the pre-installed PowerShell 5.

@sxyazi
Copy link
Owner

sxyazi commented Nov 22, 2024

Moved to yazi-rs/yazi-rs.github.io#170 as it's an error with the doc not Yazi itself

Closing in favor of that issue

@sxyazi sxyazi closed this as not planned Won't fix, can't repro, duplicate, stale Nov 22, 2024
@sxyazi sxyazi added invalid This doesn't seem right and removed bug Something isn't working help wanted Extra attention is needed labels Nov 22, 2024
Copy link

I'm going to lock this issue because it has been closed for 30 days. ⏳
This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please file a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants