Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrolling limited to some height in yazi #1699

Closed
AnirudhG07 opened this issue Sep 28, 2024 · 8 comments · Fixed by #1736
Closed

scrolling limited to some height in yazi #1699

AnirudhG07 opened this issue Sep 28, 2024 · 8 comments · Fixed by #1736
Labels
bug Something isn't working

Comments

@AnirudhG07
Copy link

What system are you running Yazi on?

Linux X11

What terminal are you running Yazi in?

WezTerm

yazi --debug output

Yazi
    Version: 0.3.3 (7222e17 2024-09-20)
    Debug  : false
    OS     : linux-x86_64 (unix)

Ya
    Version: 0.3.3 (7222e17 2024-09-20)

Emulator
    Emulator.via_env: ("xterm-256color", "WezTerm")
    Emulator.via_csi: Ok(WezTerm)
    Emulator.detect : WezTerm

Adapter
    Adapter.matches: Iip

Desktop
    XDG_SESSION_TYPE           : Some("x11")
    WAYLAND_DISPLAY            : None
    DISPLAY                    : Some(":2")
    SWAYSOCK                   : None
    HYPRLAND_INSTANCE_SIGNATURE: None
    WAYFIRE_SOCKET             : None

SSH
    shared.in_ssh_connection: false

WSL
    WSL: false

Variables
    SHELL              : Some("/bin/bash")
    EDITOR             : Some("nvim")
    VISUAL             : Some("nvim")
    YAZI_FILE_ONE      : None
    YAZI_CONFIG_HOME   : None

Text Opener
    default: Some(Opener { run: "${EDITOR:=vi} \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: true })
    block  : Some(Opener { run: "${EDITOR:=vi} \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: true })

Multiplexers
    TMUX               : true
    tmux version       : 3.4
    ZELLIJ_SESSION_NAME: None
    Zellij version     : No such file or directory (os error 2)

Dependencies
    file             : 5.41
    ueberzugpp       : No such file or directory (os error 2)
    ffmpegthumbnailer: 2.2.2
    magick           : 7.1.1-36
    fzf              : 0.55.0
    fd               : 10.1.0
    rg               : 14.1.0
    chafa            : 
    zoxide           : 0.9.4
    7z               : 17.05
    7zz              : No such file or directory (os error 2)
    jq               : 1.7.1


--------------------------------------------------
When reporting a bug, please also upload the `yazi.log` log file - only upload the most recent content by time.
You can find it in the "/home/anirudhgupta/.local/state/yazi" directory.

Did you try the latest nightly build to see if the problem got fixed?

Yes, and I updated the debug information above (yazi --debug) to the nightly that I tried

Describe the bug

When you are scrolling some file, it stop under small heights of TMUX preview.

Screencast.from.29-09-24.12.15.09.AM.IST.webm

Minimal reproducer

Take any file, keep decreasing the height in TMUX, and you ll see that scrolling stops.

Anything else?

Again, just discovered by chance. :D
Is it supposed to be like this? like is it intended or a bug?

@AnirudhG07 AnirudhG07 added the bug Something isn't working label Sep 28, 2024
@sxyazi
Copy link
Owner

sxyazi commented Sep 29, 2024

Are you referring to the preview scroll being reset when the terminal size changes? If so, that's by design to simplify the design, assuming users won't frequently change their terminal window size during the preview.

@sxyazi sxyazi added the waiting on op Waiting for more information from the original poster label Sep 29, 2024
@AnirudhG07
Copy link
Author

AnirudhG07 commented Sep 29, 2024

Nono. I mean that when the height is bigger, u r able to scroll down the preview.
But when height is small, u r not able to scroll down the preview.
I am not talking about preview being reset.

@github-actions github-actions bot removed the waiting on op Waiting for more information from the original poster label Sep 29, 2024
@sxyazi
Copy link
Owner

sxyazi commented Sep 29, 2024

I can't reproduce it:

screenshot-002042.mp4

Did you use any custom configs/plugins? Can you reproduce it with the default config (mv ~/.config/yazi ~/.config/yazi-backup)?

Also I noticed you're not using the latest nightly version; can you reproduce it with the latest nightly?

@sxyazi sxyazi added the waiting on op Waiting for more information from the original poster label Sep 29, 2024
@AnirudhG07
Copy link
Author

AnirudhG07 commented Oct 4, 2024

Yes i removed all plugins and configurations, Used the nightly build. Stil when i "mouse scroll", i am unable to scroll down. after a certain height as shown in the preview.

@github-actions github-actions bot removed the waiting on op Waiting for more information from the original poster label Oct 4, 2024
@sxyazi
Copy link
Owner

sxyazi commented Oct 5, 2024

Have you tried running it outside of tmux to see if it works? Also, are you using key scrolling or mouse scrolling? Could you check if the behavior changes with #1328 (comment) ?

@sxyazi sxyazi added the waiting on op Waiting for more information from the original poster label Oct 5, 2024
@AnirudhG07
Copy link
Author

Inside of TMUX, "mouse scrolling" doesnt work. Keyboard works just fine.
Outside of TMUX, weirdly up mouse scrolling works, not downwards. Keyboard works just fine both direction.

Yes with the mentioned changes, it works perfectly inside and outside tmux.

@github-actions github-actions bot removed the waiting on op Waiting for more information from the original poster label Oct 5, 2024
@sxyazi
Copy link
Owner

sxyazi commented Oct 5, 2024

Please try #1736

Copy link

github-actions bot commented Nov 5, 2024

I'm going to lock this issue because it has been closed for 30 days. ⏳
This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please file a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants