Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Smells for FitVox - Practice Session 12 #28

Open
jaeyeonkim99 opened this issue Nov 26, 2021 · 0 comments
Open

Code Smells for FitVox - Practice Session 12 #28

jaeyeonkim99 opened this issue Nov 26, 2021 · 0 comments

Comments

@jaeyeonkim99
Copy link
Contributor

jaeyeonkim99 commented Nov 26, 2021

Code smells we found for our project is as follows.

  1. No CSRF protection.
    For development convenience, we developed the features without considering CSRF protection till now, using @csrf_exempt in the Django backend. We will soon add appropriate codes to enable CSRF protection.

  2. Repetitive Codes in Backend
    Same codes for checking user authentication are repeated in every function in the views.py of the django backend. We will refactor the code and remove the duplicated codes using the decorator.

  3. Imports of Unnecessary Modules
    For frontend codes, we've temporary imported some modules which are not actually used after the final implementation. We will remove this unnecessary import statements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant