Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increasing the number of threads Seg Faults #104

Open
shloksobti opened this issue Feb 21, 2023 · 1 comment
Open

Increasing the number of threads Seg Faults #104

shloksobti opened this issue Feb 21, 2023 · 1 comment

Comments

@shloksobti
Copy link

shloksobti commented Feb 21, 2023

Hi!
I'm running into some segfault bugs, where if I attempt to use more than 1 thread, I get pure virtual method called. This is true for all solvers. Do I need to provide an implementation of handling threads?
Curious if this is a known issue?

@marip8
Copy link
Collaborator

marip8 commented Feb 21, 2023

If I remember correctly, all of the unit tests and benchmarks are set to be single-threaded because the BGL classes are not thread-safe. We should probably change them to be single-threaded or add locks around the critical areas, but I don't think that's been done yet.

I think the LadderGraph solver should be thread-safe if the interface implementations are also thread-safe. I believe the implementations provided in this repository should be thread-safe. Our main "real" implementation in tesseract uses the LadderGraph solver, but defaults to being single threaded, so it's possible that we're incorrect here.

Can you provide more detail on the segfault (e.g., line number, etc.) and what solvers, samplers, edge/state evaluators you are using?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants