Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E Tests: Code coverage #73

Closed
swissspidy opened this issue Jul 13, 2023 · 0 comments
Closed

E2E Tests: Code coverage #73

swissspidy opened this issue Jul 13, 2023 · 0 comments

Comments

@swissspidy
Copy link
Owner

swissspidy commented Jul 13, 2023 •
edited
Loading

Would be nice to test the most common scenario(s)

  1. Upload a new image through Media -> Add New
  2. Insert image in a blog post
  3. Optimize image
  4. See before/after comparison
  5. Approve change
  6. Verify image has been replaced
  7. Verify thumbnail generation worked, maybe with snapshots

Collecting code coverage would be superb. Would be useful for other projects as well.

See https://github.com/search?q=playwright+v8toIstanbul+stopJSCoverage&type=code as a starting point.

https://github.com/bgotink/playwright-coverage looks promising.

So does https://github.com/cenfun/monocart-reporter

Apparently there might be a bug with v8->istanbul conversion, see istanbuljs/v8-to-istanbul#216 and cenfun/monocart-reporter#50 (found via microsoft/playwright#7030)

Probably need to build the JS with source maps
swissspidy added a commit that referenced this issue Dec 2, 2023
@swissspidy
Add basic e2e tests
c3083d3 
See #73
@swissspidy swissspidy changed the title E2E Tests E2E Tests: Code coverage Dec 2, 2023
@swissspidy swissspidy mentioned this issue Dec 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@swissspidy