refactor provisioningParamsAreChanged, do not check sequence and the …

…amount of parameters
swisscom · Sep 26, 2023 · ce8a8a1 · ce8a8a1
1 parent 411752e
commit ce8a8a1
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/pkg/controller/servicecatalog/provisionedproduct/utils.go b/pkg/controller/servicecatalog/provisionedproduct/utils.go
@@ -17,13 +17,15 @@ const (
 )
 
 func provisioningParamsAreChanged(cfStackParams []cfsdkv2types.Parameter, currentParams []*svcapitypes.ProvisioningParameter) bool {
-	if len(cfStackParams) != len(currentParams) {
-		return true
+	cfStackKeyValue := make(map[string]string)
+	for _, v := range cfStackParams {
+		cfStackKeyValue[*v.ParameterKey] = pointer.StringDeref(v.ParameterValue, "")
 	}
 
-	for i, v := range cfStackParams {
-		if pointer.StringDeref(currentParams[i].Key, "") != pointer.StringDeref(v.ParameterKey, "") ||
-			pointer.StringDeref(currentParams[i].Value, "") != pointer.StringDeref(v.ParameterValue, "") {
+	for _, v := range currentParams {
+		if cfv, ok := cfStackKeyValue[*v.Key]; ok && pointer.StringEqual(&cfv, v.Value) {
+			continue
+		} else {
 			return true
 		}
 	}