You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Catalog.estimate_mc and Catalog.estimate_b need to be tested.
Since the methods estimate_b and mc_ks already should be tested, you only need to check whether they are called correctly, depending on the various combinations of input.
As a minimal example, there is already a test in seismicity/tests/test_catalog.py -> test_catalog_bin which tests whether the bin_to_precision method is correctly called. You will need to do some more validation on the input parameters. (delta_m = None or not, and so on).
The text was updated successfully, but these errors were encountered:
There's a branch with this now, I added some of the tests, but for estimate_b and mc, it only checks error raising. I am not sure how much we should add and what is redundant due to already existing tests, anyways to be continued. I also changed some things about the underlying binning function and the corresponding test.
Catalog.estimate_mc
andCatalog.estimate_b
need to be tested.Since the methods
estimate_b
andmc_ks
already should be tested, you only need to check whether they are called correctly, depending on the various combinations of input.As a minimal example, there is already a test in seismicity/tests/test_catalog.py ->
test_catalog_bin
which tests whether thebin_to_precision
method is correctly called. You will need to do some more validation on the input parameters. (delta_m = None or not, and so on).The text was updated successfully, but these errors were encountered: